aws/ec2: properly paginate DescribeNetworkInterfaces results#6
Open
MitchLewis930 wants to merge 1 commit intopr_046_beforefrom
Open
aws/ec2: properly paginate DescribeNetworkInterfaces results#6MitchLewis930 wants to merge 1 commit intopr_046_beforefrom
MitchLewis930 wants to merge 1 commit intopr_046_beforefrom
Conversation
Signed-off-by: Anton Ippolitov <anton.ippolitov@datadoghq.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| Values: []string{"*"}, | ||
| }, | ||
| }, | ||
| MaxResults: aws.Int32(defaults.ENIMaxResultsPerApiCall), |
There was a problem hiding this comment.
MaxResults and NetworkInterfaceIds cannot be used together
High Severity
The AWS EC2 DescribeNetworkInterfaces API explicitly prohibits specifying both MaxResults and NetworkInterfaceIds in the same request. In describeNetworkInterfacesFromInstances, MaxResults is unconditionally set to 1000, and then NetworkInterfaceIds is conditionally set when enisListFromInstances is non-empty. When instances with ENIs exist, both parameters will be set, causing an AWS API error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_046
Note
Low Risk
Small change limited to AWS ENI listing request parameters; primary risk is altered API call sizing/throughput impacting rate limits or performance in large environments.
Overview
Ensures EC2
DescribeNetworkInterfacesrequests consistently paginate by settingMaxResultson ENI listing calls, using a new default (defaults.ENIMaxResultsPerApiCall = 1000).This updates the EC2 client’s ENI discovery paths (all-ENI, by-instance, and by-instances filters) to cap per-call results and rely on the paginator to fetch remaining pages.
Written by Cursor Bugbot for commit 7e21480. This will update automatically on new commits. Configure here.